Skip to content

Commit

Permalink
refactor: move shared library tests to their own file (denoland#18479)
Browse files Browse the repository at this point in the history
  • Loading branch information
ry committed Mar 28, 2023
1 parent e789f81 commit 35fd858
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 39 deletions.
35 changes: 0 additions & 35 deletions cli/tests/integration/linux_tests.rs

This file was deleted.

6 changes: 2 additions & 4 deletions cli/tests/integration/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,8 @@ mod install;
mod js_unit_tests;
#[path = "lint_tests.rs"]
mod lint;
#[path = "linux_tests.rs"]
mod linux;
#[path = "lsp_tests.rs"]
mod lsp;
#[path = "macos_tests.rs"]
mod macos;
#[path = "node_compat_tests.rs"]
mod node_compat_tests;
#[path = "node_unit_tests.rs"]
Expand All @@ -139,6 +135,8 @@ mod npm;
mod repl;
#[path = "run_tests.rs"]
mod run;
#[path = "shared_library_tests.rs"]
mod shared_library_tests;
#[path = "task_tests.rs"]
mod task;
#[path = "test_tests.rs"]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,39 @@
// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.

#[cfg(all(target_os = "linux", target_arch = "x86_64"))]
#[test]
// https://github.com/denoland/deno/issues/18266
fn linux_shared_libraries() {
use test_util as util;

const EXPECTED: [&str; 7] = [
"linux-vdso.so.1",
"libdl.so.2",
"libgcc_s.so.1",
"libpthread.so.0",
"libm.so.6",
"libc.so.6",
"/lib64/ld-linux-x86-64.so.2",
];

let ldd = std::process::Command::new("ldd")
.arg("-L")
.arg(util::deno_exe_path())
.output()
.expect("Failed to execute ldd");

let output = std::str::from_utf8(&ldd.stdout).unwrap();
// Ensure that the output contains only the expected shared libraries.
for line in output.lines().skip(1) {
let path = line.split_whitespace().next().unwrap();
assert!(
EXPECTED.contains(&path),
"Unexpected shared library: {}",
path
);
}
}

#[cfg(target_os = "macos")]
#[test]
// https://github.com/denoland/deno/issues/18243
Expand Down

0 comments on commit 35fd858

Please sign in to comment.