Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring HTTP client for better consistency and maintainability #401

Merged
merged 32 commits into from
Feb 16, 2024
Merged

Refactoring HTTP client for better consistency and maintainability #401

merged 32 commits into from
Feb 16, 2024

Conversation

waybackarchiver
Copy link
Contributor

@waybackarchiver waybackarchiver commented May 19, 2023 •
edited
Loading

Description

Closes #112

Checklist

@waybackarchiver waybackarchiver added documentation Improvements or additions to documentation enhancement New feature or request go Pull requests that update Go code labels May 19, 2023
@waybackarchiver waybackarchiver mentioned this pull request May 19, 2023
Merged
3 tasks
@codecov
Copy link

codecov bot commented May 19, 2023 •
edited
Loading

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (ebb3a30) 47.73% compared to head (eb79a14) 43.95%.
Report is 4 commits behind head on main.

Files Patch % Lines
ingress/http.go 5.35% 53 Missing ⚠️
cmd/wayback/serve.go 0.00% 3 Missing ⚠️
ingress/init.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
- Coverage   47.73%   43.95%   -3.78%     
==========================================
  Files          69       84      +15     
  Lines        5721     6647     +926     
==========================================
+ Hits         2731     2922     +191     
- Misses       2719     3438     +719     
- Partials      271      287      +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

It has been open 120 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Sep 23, 2023
@github-actions github-actions bot closed this Sep 30, 2023
@github-actions github-actions bot removed the Stale label Oct 7, 2023
@github-actions GitHub Actions
Copy link

It has been open 120 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Feb 10, 2024
@waybackarchiver waybackarchiver marked this pull request as ready for review February 16, 2024 04:06
waybackarchiver
waybackarchiver commented Feb 16, 2024
View reviewed changes
reduxer/reduxer.go Outdated Show resolved Hide resolved
@waybackarchiver waybackarchiver merged commit ceafbdf into main Feb 16, 2024
139 checks passed
@waybackarchiver waybackarchiver deleted the http-client branch February 16, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring http client
1 participant
@waybackarchiver