Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set NoWait to true for tor listen config #368

Merged
merged 3 commits into from
Apr 16, 2023
Merged

Conversation

waybackarchiver
Copy link
Contributor

Description

In certain network scenarios, starting an onion service may cause a blockage that also affects the clear web service. To avoid this issue, set the NoWait parameter to true. This will allow the web service to start without delay, even in the presence of network congestion or other issues.

Checklist

In certain network scenarios, starting an onion service may cause
a blockage that also affects the clear web service. To avoid this
issue, set the `NoWait` parameter to `true`.
This will allow the web service to start without delay, even in
the presence of network congestion or other issues.
@waybackarchiver waybackarchiver added enhancement New feature or request go Pull requests that update Go code labels Apr 16, 2023
@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (546785e) 47.10% compared to head (78769e6) 47.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   47.10%   47.09%   -0.01%     
==========================================
  Files          58       58              
  Lines        5129     5130       +1     
==========================================
  Hits         2416     2416              
- Misses       2451     2452       +1     
  Partials      262      262              
Impacted Files Coverage Δ
service/httpd/tor.go 6.45% <0.00%> (-0.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waybackarchiver waybackarchiver merged commit 5fe18b7 into main Apr 16, 2023
@waybackarchiver waybackarchiver deleted the onion-service-nowait branch April 16, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant