Add debug tools to argoexec image. Remove privileged mode from sideki…

…ck. Disable linting

Dockerfile-argoexec

@@ -1,5 +1,9 @@
 FROM debian:9.1
 
+RUN apt-get update && \
+ apt-get install -y curl jq procps && \
+ rm -rf /var/lib/apt/lists/*
+
 COPY dist/argoexec /bin/
 
 ENTRYPOINT [ "/bin/argoexec" ]

Makefile

@@ -30,7 +30,7 @@ IMAGE_PREFIX=${IMAGE_NAMESPACE}/
 endif
 
 # Build the project
-all: lint cli-linux cli-darwin workflow-image apiserver-image argoexec-image
+all: cli-linux cli-darwin workflow-image apiserver-image argoexec-image
 
 builder:
  docker build -t ${BUILDER_IMAGE} -f Dockerfile-builder .

workflow/controller/workflowpod.go

@@ -166,7 +166,7 @@ func (wfc *WorkflowController) newInitContainer(tmpl *wfv1.Template) (*corev1.Co
 }
 
 func (wfc *WorkflowController) newWaitContainer(tmpl *wfv1.Template) (*corev1.Container, error) {
- ctr := wfc.newExecContainer(common.WaitContainerName, true)
+ ctr := wfc.newExecContainer(common.WaitContainerName, false)
  ctr.Command = []string{"sh", "-c"}
  argoExecCmd := fmt.Sprintf("echo sleeping; cat %s; sleep 10; echo done", common.PodMetadataAnnotationsPath)
  ctr.Args = []string{argoExecCmd}
@@ -238,6 +238,12 @@ func addInputArtifactVolumes(pod *corev1.Pod, tmpl *wfv1.Template) error {
  mainCtr = &ctr
  break
  }
+ if ctr.Name == common.WaitContainerName {
+ // HACK: debug purposes. sleep to experiment with wait container artifacts
+ ctr.Command = []string{"sh", "-c"}
+ ctr.Args = []string{"sleep 999999; echo done"}
+ pod.Spec.Containers[i] = ctr
+ }
  }
  if mainCtr == nil {
  errors.InternalError("Could not find main container in pod spec")