fix(cli): Show lint errors of all files (argoproj#2552)

Co-authored-by: Simon Behar <[email protected]>

cmd/argo/commands/lint.go

@@ -5,12 +5,13 @@ import (
  "os"
  "path/filepath"
 
- "github.com/argoproj/pkg/errors"
+ log "github.com/sirupsen/logrus"
  "github.com/spf13/cobra"
 
  "github.com/argoproj/argo/cmd/argo/commands/client"
  workflowpkg "github.com/argoproj/argo/pkg/apiclient/workflow"
  "github.com/argoproj/argo/workflow/validate"
+ "github.com/argoproj/pkg/errors"
 )
 
 func NewLintCommand() *cobra.Command {
@@ -40,24 +41,36 @@ func NewLintCommand() *cobra.Command {
  return nil
  }
 
+ var invalidWfErr error
  for _, file := range args {
  stat, err := os.Stat(file)
  errors.CheckError(err)
  if stat.IsDir() {
- err := filepath.Walk(file, func(path string, info os.FileInfo, err error) error {
+ _ = filepath.Walk(file, func(path string, info os.FileInfo, err error) error {
  fileExt := filepath.Ext(info.Name())
  switch fileExt {
  case ".yaml", ".yml", ".json":
  default:
  return nil
  }
- return lint(path)
+ err = lint(path)
+ if err != nil {
+ invalidWfErr = fmt.Errorf("Invalid workflow/workflows found")
+ log.Warn(err)
+ }
+ return nil
  })
- errors.CheckError(err)
  } else {
  err := lint(file)
- errors.CheckError(err)
+ if err != nil {
+ invalidWfErr = fmt.Errorf("Invalid workflow/workflows found")
+ log.Warn(err)
+ }
  }
+ err = nil
+ }
+ if invalidWfErr != nil {
+ errors.CheckError(invalidWfErr)
  }
  fmt.Printf("Workflow manifests validated\n")
  },