Update issue reference in CSS patch for css-gcpm #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue was closed in CSSTree project as plan is to change the syntax in CSS Syntax instead.
dontcallmedom
approved these changes
Sep 6, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was closed in CSSTree project as plan is to change the syntax in CSS Syntax instead.
This is meant to replace #1331.
Side note: we don't need a patch on CSS Syntax because
<an+b>is thenameof the construct and not itsvalue, and our tests only check that values can be parsed with CSSTree. Now that I think about it, that's probably an oversight, the guarantee should extend to names as well: if the names can't be parsed, they cannot be used as values in any case. I'll propose to refine the test separately (testing locally,<an+b>would be the only problematic name).