Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CapabilitiesRequest CDDL definition #222

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Fix CapabilitiesRequest CDDL definition #222

merged 1 commit into from
Jun 7, 2022

Conversation

whimboo
Copy link
Contributor

@whimboo whimboo commented Jun 7, 2022 •
edited by pr-preview bot
Loading

Fixes issue #218.

Preview | Diff

@whimboo
Copy link
Contributor Author

whimboo commented Jun 7, 2022

@jgraham any idea why the Rust CDDL implementation that we now run in Github CI doesn't detect this unresolved symbol for CapabilitiesRequestParameters?

jgraham
jgraham approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why it's not detected by the CDDL. I think we really need to do some infra work to have a CI check which tries to validate some example messages in order to stach more mistakes.

@whimboo whimboo mentioned this pull request Jun 7, 2022
Closed
@whimboo
Copy link
Contributor Author

whimboo commented Jun 7, 2022

Thanks @jgraham. I filed issue #223 for that particular work.

@whimboo whimboo merged commit f2fcb24 into w3c:master Jun 7, 2022
@whimboo whimboo deleted the capabilities_request branch June 7, 2022 09:53
@whimboo whimboo mentioned this pull request Jun 7, 2022
Closed
github-actions bot added a commit that referenced this pull request Jun 7, 2022
@whimboo @github-actions
Fix CapabilitiesRequest CDDL definition (#222)
477a6d2 
SHA: f2fcb24
Reason: push, by @whimboo

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgraham jgraham jgraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whimboo @jgraham