Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ownership to resultOwnership in script.callFunction #221

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Rename ownership to resultOwnership in script.callFunction #221

merged 1 commit into from
Jun 7, 2022

Conversation

sadym-chromium
Copy link
Contributor

@sadym-chromium sadym-chromium commented Jun 6, 2022 •
edited by pr-preview bot
Loading

Unify script.evaluate and script.callFunction

Preview | Diff

@sadym-chromium sadym-chromium changed the title ownership -> resultOwnership in script.callFunction Rename ownership -> resultOwnership in script.callFunction Jun 6, 2022
@sadym-chromium sadym-chromium changed the title Rename ownership -> resultOwnership in script.callFunction Rename ownership in resultOwnership in script.callFunction Jun 6, 2022
@sadym-chromium sadym-chromium changed the title Rename ownership in resultOwnership in script.callFunction Rename ownership to resultOwnership in script.callFunction Jun 6, 2022
whimboo
whimboo approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@whimboo whimboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me.

@sadym-chromium sadym-chromium merged commit 0f999e3 into master Jun 7, 2022
@sadym-chromium sadym-chromium deleted the resultOwnership branch June 7, 2022 09:45
github-actions bot added a commit that referenced this pull request Jun 7, 2022
@sadym-chromium @github-actions
ownership -> resultOwnership in script.callFunction (#221)
da7e1fb 
SHA: 0f999e3
Reason: push, by @sadym-chromium

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whimboo whimboo whimboo approved these changes

@jgraham jgraham Awaiting requested review from jgraham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sadym-chromium @whimboo