Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add PULL_REQUEST_TEMPLATE.md #48

Merged
merged 3 commits into from
Jul 2, 2020

Conversation

Johanna-hub
Copy link
Contributor

(👋 I'm an Outreachy intern at Mozilla and assisting @marcoscaceres with specifications)

During TPAC it was proposed to adopt something closer to the WHATWG Working Mode. That is, before merging a pull request, the following things should be in place:

  • Web Platform tests for the feature/fix being proposed.
  • Explicit implementer commitment to add/fix whatever is being proposed.

This template provides some simple checkboxes to make sure the above conditions are met. We strongly encourage using this template, since it helps implementers find tests and sends a strong signal about implementation commitment. You are free to modify it to better suit your needs (see an example of a modified template).

If you are unsure how to create Web Platform Tests, there are some great docs available. We are also here to help you get started if you need guidance.

@marcoscaceres marcoscaceres merged commit 3f620a4 into w3c:gh-pages Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants