[css extraction] Ignore empty lines in table definitions #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I cannot reproduce it, but Bikeshed generated an empty line at the end of the table definition of `font-style` in css-fonts-4. The extraction logic did not expect that and crashed. This update makes the extraction logic more resilient by ignoring empty lines. Via w3c/webref#1130
dontcallmedom
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cannot reproduce it, but Bikeshed generated an empty line at the end of the table definition of
font-stylein css-fonts-4. The extraction logic did not expect that and crashed.This update makes the extraction logic more resilient by ignoring empty lines.
Via w3c/webref#1130