Fix HTML syntax errors in the source #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `<div/>` is invalid, it needs the full end tag. * Remove `longdesc` (invalid & redundant with the link). * Remove unneccessary comment before the doctype.
|
On a related note, it seems the Acknowledgment includes don't work in https://w3c.github.io/aria/#acknowledgements |
I believe this only works in the published versions but @michael-n-cooper can confirm this. |
jnurthen
requested changes
May 21, 2019
common/acknowledgements.html
Outdated
| <div data-include="acknowledgements/aria-wg-active.html" data-include-replace="true"/> | ||
| <div data-include="acknowledgements/aria-contributors.html" data-include-replace="true"/> | ||
| <div data-include="acknowledgements/funders.html" data-include-replace="true"/> | ||
| <div data-include="acknowledgements/aria-wg-active.html" data-include-replace="true"></div> |
There was a problem hiding this comment.
Can you remove this from this PR. The common directory is maintained in the w3c/aria-common repository.
|
PR in aria-common: w3c/aria-common#32 |
jnurthen
approved these changes
May 22, 2019
jnurthen
pushed a commit
that referenced
this pull request
May 22, 2019
|
Thanks. |
carmacleod
pushed a commit
that referenced
this pull request
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<div/>is invalid, it needs the full end tag.longdesc(invalid & redundant with the link).Preview | Diff