-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virmata rohkost #99
Virmata rohkost #99
Conversation
hei jens, isn't it so that the Arduino (Devices StandardFirmata 2.x) module seen from outside looks/works exactly the same as before only with new innards?! if so we'd not need a legacy version of it since you can simply fix it up internally and users of that node will not notice any difference. only for the FirmataEncode/Decode node it really needs the legacy nodes as their pins have changed, right? being picky: |
hi ioreg! right, the data type changed on the pins, so the string versions of the actual plugin nodes are Legacy and should not be used anmore! |
hm. there is actually some strange behavour, when a node gets Legacy, the same as renamed so to speak(right?) and changing a pin naming on the new node. if i add a pin child to the xml node, i get a crash right before any patch appears - a parser error the exception dialog says. |
meinem gefühl nach i'd suggest something like this for your situation:
<NODE old="FirmataEncode (Devices 2.x)" new="FirmataEncode (Devices 2.x Legacy)"></NODE>
<NODE old="FirmataDecode (Devices 2.x)" new="FirmataDecode (Devices 2.x Legacy)"></NODE>
<NODE old="Arduino (Devices StandardFirmata 2.x)">
<PIN old="PinModes" new="Pin Modes"> </PIN>
...
</NODE> |
yeah! that's how i got it. i found my error on testing the pin renaming. i did set the patch version back to 28.1 and the pins were connected correctly. nevertheless this is not reflected in a patch with the current version. but that can be reconnected and is a new version anyways. right? of course i will set the help patch back to the current version 29.1. i was trying to figure how the substitution works. here is my xml snippet: <PATCH version="current">
<NODE old="FirmataEncode (Devices 2.x)" new="FirmataEncode (Devices 2.x String Legacy)"></NODE>
<NODE old="FirmataDecode (Devices 2.x)" new="FirmataDecode (Devices 2.x String Legacy)"></NODE>
<NODE old="I2CDecode (Devices 2.x)" new="I2CDecode (Devices 2.x String Legacy)">
<PIN old="I2CData" new="I2C Data"></PIN>
</NODE>
<NODE old="Arduino (Devices StandardFirmata 2.x)">
<PIN old="SampleRate" new="Samplerate"></PIN>
<PIN old="PinModes" new="Pin Modes"></PIN>
<PIN old="ReportAnalog" new="Report Analog Pins"></PIN>
<PIN old="ReportDigital" new="Report Digital Pins"></PIN>
<PIN old="Analog" new="Analog In"></PIN>
<PIN old="Digital" new="Digital In"></PIN>
<PIN old="OnData" new="On Data"></PIN>
<PIN old="Firmwareversion" new="Firmware Version"></PIN>
</NODE>
</PATCH> |
looks good except:
the helppatches you can update manually that they definitely reference the new versions of the node. now the ultimate test is:
|
:) i see the Legasee ;) yes, that has been working before. don't know, what has gotten me to rename, i think some strange error about parse. well it compiles and works fine for me. let's hope i can get some more stuff done before the release! |
btw. i discovered that error of a trialing white space behind the |
not sure where you mean there was a trailing white space behind the Devices category? |
thx herr ioreg! |
merged in now. and tested all to work. even the I2C loads fine as legacy when opening a patch saved with b29 |
:) yes! it is always rising heartbeat... |
Hi devvvvs!
The Firmata plugin is ported to raw + some features like full use of all pins and generic pin mode settings are implemented and tested as far as possible. Also i had the chance to test the i2c decoding. Changes in the plugin are reflected in the module and the matching help patch.
The old nodes are versioned Legacy and also marked as such in the diffff.xml. I hope got that one right!? In my builds they do not show up, as expected.
Happy to fix any mis-use or in-compliance!
greetz!