IIntersectable... #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eManagement and use it's internal references instead
… a version supporting Net6, and include Netonsoft.Json that used to be bundled with the old version.
user settings autogen
…es once a certificate is setup)
was hoping it would help resolve build hanging issues. It might have helped but was not a solution.
…ncies. was hoping it would help fix runtime IL bug with animation system, but it did not help. see: stride3d#1136
# build/Stride.Launcher.Build.props # samples/Audio/SimpleAudio/SimpleAudio.Windows/SimpleAudio.Windows.csproj # samples/Games/JumpyJet/JumpyJet.Windows/JumpyJet.Windows.csproj # samples/Games/SpaceEscape/SpaceEscape.Windows/SpaceEscape.Windows.csproj # samples/Graphics/AnimatedModel/AnimatedModel.Windows/AnimatedModel.Windows.csproj # samples/Graphics/CustomEffect/CustomEffect.Windows/CustomEffect.Windows.csproj # samples/Graphics/MaterialShader/MaterialShader.Windows/MaterialShader.Windows.csproj # samples/Graphics/SpriteFonts/SpriteFonts.Windows/SpriteFonts.Windows.csproj # samples/Graphics/SpriteStudioDemo/SpriteStudioDemo.Windows/SpriteStudioDemo.Windows.csproj # samples/Input/GravitySensor/GravitySensor.Windows/GravitySensor.Windows.csproj # samples/Input/TouchInputs/TouchInputs.Windows/TouchInputs.Windows.csproj # samples/Particles/ParticlesSample/ParticlesSample.Windows/ParticlesSample.Windows.csproj # samples/Physics/PhysicsSample/PhysicsSample.Windows/PhysicsSample.Windows.csproj # samples/Templates/FirstPersonShooter/FirstPersonShooter/FirstPersonShooter.Windows/FirstPersonShooter.Windows.csproj # samples/Templates/ThirdPersonPlatformer/ThirdPersonPlatformer/ThirdPersonPlatformer.Windows/ThirdPersonPlatformer.Windows.csproj # samples/Templates/TopDownRPG/TopDownRPG/TopDownRPG.Windows/TopDownRPG.Windows.csproj # samples/Templates/VRSandbox/VRSandbox/VRSandbox.Windows/VRSandbox.Windows.csproj # samples/Tutorials/CSharpBeginner/CSharpBeginner/CSharpBeginner.Windows/CSharpBeginner.Windows.csproj # samples/UI/GameMenu/GameMenu.Windows/GameMenu.Windows.csproj # samples/UI/UIElementLink/UIElementLink.Windows/UIElementLink.Windows.csproj # samples/UI/UIParticles/UIParticles.Windows/UIParticles.Windows.csproj # sources/assets/Stride.Core.Assets.CompilerApp/build/Stride.Core.Assets.CompilerApp.targets # sources/launcher/Stride.Launcher/Stride.Launcher.csproj # sources/shared/Stride.NuGetResolver/Stride.NuGetResolver.projitems # sources/targets/Stride.Core.TargetFrameworks.Editor.props # sources/targets/Stride.Core.props # sources/tools/Stride.NuGetLoader/Stride.NuGetLoader.csproj
…See stride3d#1136 (comment) This commit takes my "last known good" net6 work prior to merging [de0a0cb] and verifies build. I am integrating in the non-required net6 work because of how time consuming it is to verify+maintain each branch. Tracking this issue down and reproducing takes aproximately 1 hour per commit. So to reduce this waste of time I will be maintaining a single net6 branch. This commit removes some test projects from the stride solutions
…rApp.exe merge issue from [de0a0cb] .
acutally -> actually
Fix typo in XAudio2.cpp
… of the path The launcher executable was moved to a new tools directory as part of the fix for stride3d#1139. Older packages did not contain a tools directory so added code to check for the existence of a target directory before delving into it. Also tightened up the code in the affected area and removed an unused using statement.
1) Replaced all insances of WebRequest with HttpClient plus the appropriate Get + Read operations. 2) Replaced the use of WebClient with HttpClient plus Get + stream read. 3) Removed semi-problematic refereces and the SDK specifier as they caused the compiler to generate a number of warnings. All these are not needed in .NET 6.
1) HttpResponseMessage (return from HttpClient.GetAsync) should be disposed so added using statements as appropriate. In some cases the code was slightly rearranged for readability with this update. 2) Since the BaseUrl is never actually used elsewhere, removed updating it in ReleaseNotesViewModel.cs 3) Removed unneeded setting of stream pointers to their head immediately after creation since they will be that way already. 4) In NewsPageViewModel.cs, converted the use of MemoryStream to the return type of ReadAsStreamAsync, Stream, since it allows for the same usage in the following code and avoids a potentially risky cast.
Fix for Issue stride3d#1361 - Replace deprecated WebRequest & WebClient
Fix for issue stride3d#1185 - Stride.Launcher - Could not find a part of the path
…1346 [Rendering] Fixes null exception on first frame. stride3d#1343
…rinker03 docs: add jrinker03 as a contributor for code
…ristanmcpherson docs: add tristanmcpherson as a contributor for code
…ET SDK to eliminate compiler warning. (stride3d#1364)
…g safety or by changing the type used. Also removed some commented out debugging code.
Fixes the following warnings:
- CS0108 'OldCollectionDescriptor.IsCollection(Type)' hides inherited member 'CollectionDescriptor.IsCollection(Type)'. Use the new keyword if hiding was intended.
- CS0162 Unreachable code
- CS0168 The variable 'e' is declared but never used
- CS0169 The field 'foo' is never used
- CS0184 The given expression is never of the provided ('ProjectViewModel') type
Plus some minor using cleanup and making code a tad more consistent.
…' rather than the deprecated licenseUrl.
…ince it's used conditionally.
Update stride package definitions to use a license expression of 'MIT' rather than the deprecated licenseUrl.
Warning fixes for C# code, part 1
Address CPP compiler warnings by explicitly casting values after examining safety or by changing the type used. Also removed some commented out debugging code.
… BoundingSphere and Plane) and IIntersectableWithPlane (implemented by BoundingBox and BoundingSphere)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
got accepted on master