Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add background support on DIV and A elements. #74

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: add background support on DIV and A elements. #74

wants to merge 5 commits into from

Conversation

euskadi31
Copy link

No description provided.

@vvo
Copy link
Owner

vvo commented Mar 14, 2016

Hi! Thanks for the contribution.

Once you are done (maybe already the case?), can you:

  • provide some context (what are you trying to do? Is there already a linked issue? Maybe we can make this a plugin or a recipe, should this be in core?)
  • document the API in the github issue (we will then see if it's a good fit, how do we make it to the readme)
  • remove the built file from the commit (I will build it when releasing if necessary)

@euskadi31
Copy link
Author

I added a example for background lazyload feature.

vvo
vvo reviewed Mar 21, 2016
View reviewed changes
test/background.js
beforeEach(h.scroller(0, 0));
beforeEach(h.wait(50));

it('loads the image when visible for a while', h.eltLoaded('simple_background'));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess here what you need to check in the test is that the style property was updated with the good background. Can you do that?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep ;)

@vvo
Copy link
Owner

vvo commented Mar 21, 2016

@euskadi31 Thats very nice, can you just update the test according to my comment?

@vvo
Copy link
Owner

vvo commented Mar 21, 2016

For this PR, we still need:

  • good documentation
  • remove builds from commits

I can do that, no problem, if you want to do it that's good also. Thanks a lot for contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@euskadi31 @vvo