Update reexports in module vulkano::instance
#390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reexports
vulkano::instance::layers::LayersListError
to make it public-visible.This is necessary because a former reexport
pub use self::layers::layers_list
introducesResult<LayersIterator, LayersListError>
into the public interface. This in essence actually introduces a private type into the public interface.Most of the times there would be no problem using values of this smuggled-out type.
pub
-implemented methods and trait methods can be invoked by outer code just as if the type is actually public visible. However, when the path to this type needs to be explicitly specified, like in the case when a consumer wants to chain this error type witherror-chain
, the compiler would complain that the type is not in scope. AFAIK the only way to to solve this is via another reexport, making this type really public-visible.A quick example explaining what's going on there: