Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for descriptor set copies and other things #2219

Merged
merged 5 commits into from
Jun 3, 2023
Merged

Add support for descriptor set copies and other things #2219

merged 5 commits into from
Jun 3, 2023

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Jun 3, 2023 •
edited
Loading

Changelog:

### Breaking changes
Changes to descriptor sets and descriptor set layouts:
- `PersistentDescriptorSet::new` now takes an additional parameter, specifying descriptor set copy operations.
- `DescriptorSetLayoutCreateInfo::push_descriptor` has been replaced with a more generic `flags` field.
- `DescriptorSetLayoutBinding::variable_descriptor_count` has been replaced with a more generic `binding_flags` field.

### Additions
- `PipelineLayoutCreateInfo` now has a `flags` field.
- Added `Device::descriptor_set_layout_support` from the `khr_maintenance3` extension.

Descriptor set copies are a Vulkan 1.0 feature, but were never implemented in Vulkano for some reason. This PR adds them. It also rearranges some of the descriptor set and pipeline layout stuff to match Vulkan a bit better, and converts all the error handling to use ValidationError.

@marc0246
Copy link
Contributor

marc0246 commented Jun 3, 2023

👍

@marc0246 marc0246 merged commit 3e7ac8e into vulkano-rs:master Jun 3, 2023
3 checks passed
marc0246 added a commit that referenced this pull request Jun 3, 2023
@marc0246
#2219 changelog
52681d5
Rua added a commit that referenced this pull request Jun 3, 2023
@Rua
#2219 changelog
1e8985b
rauba-code pushed a commit to rauba-code/vulkano that referenced this pull request Jun 3, 2023
@Rua @rauba-code
Add support for descriptor set copies and other things (vulkano-rs#2219)
90198ab 
* Add support for descriptor set copies and other things

* Typo

* Errors

* Doctest fix

* Add missing non_exhaustive
rauba-code pushed a commit to rauba-code/vulkano that referenced this pull request Jun 3, 2023
@marc0246 @rauba-code
vulkano-rs#2219 changelog
0b8e29d
rauba-code pushed a commit to rauba-code/vulkano that referenced this pull request Jun 3, 2023
@Rua @rauba-code
vulkano-rs#2219 changelog
10381d8
marc0246 added a commit that referenced this pull request Jun 5, 2023
@marc0246
More #2219 additions
1f50703
@Rua Rua mentioned this pull request Jun 5, 2023
Merged
@Rua Rua deleted the dscopy branch October 25, 2023 14:25
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@Rua @hakolao
Add support for descriptor set copies and other things (vulkano-rs#2219)
b6273ae 
* Add support for descriptor set copies and other things

* Typo

* Errors

* Doctest fix

* Add missing non_exhaustive
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@marc0246 @hakolao
vulkano-rs#2219 changelog
8233364
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@Rua @hakolao
vulkano-rs#2219 changelog
b98df67
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@marc0246 @hakolao
More vulkano-rs#2219 additions
01fa6ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc0246 marc0246 marc0246 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rua @marc0246