Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove command_buffer::submit module, make new Queue methods public #2002

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Sep 25, 2022

Changelog:
Remove this line:

- `SubmitAnyBuilder` and its wrapped types no longer have a lifetime parameter, as they own their data instead. Various methods of these types now take their arguments by value.

And add:

### Breaking changes
Changes to queue operations:
- The `command_buffer::submit` module has been removed. The `SubmitAnyBuilder` enum is moved to the `sync` module, and no longer has a lifetime parameter.

### Additions
- Added `bind_sparse_unchecked`, `present_unchecked` and `submit_unchecked` methods to `QueueGuard`.

The new queue operation methods are now exposed. There may be some things that still need adjusting, and of course there need to be safe validated versions of them too.

Copy link
Member

@AustinJ235 AustinJ235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AustinJ235 AustinJ235 merged commit 6b19b6c into vulkano-rs:master Sep 27, 2022
AustinJ235 added a commit that referenced this pull request Sep 27, 2022
@Rua Rua deleted the remove-submit branch October 4, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants