Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes regarding naming and API consistency #1946

Merged
merged 4 commits into from
Aug 7, 2022
Merged

Changes regarding naming and API consistency #1946

merged 4 commits into from
Aug 7, 2022

Conversation

marc0246
Copy link
Contributor

@marc0246 marc0246 commented Aug 7, 2022

Changelog:

- Changes to `StandardCommandPool`:
  - **Breaking** `Device::standard_command_pool` has been removed in favor of `Device::with_standard_command_pool`.
- **Breaking** Changes to `StdMemoryPool`:
  - Renamed `StdMemoryPool[Alloc]`, `StdHostVisibleMemoryTypePool[Alloc]`, `StdNonHostVisibleMemoryTypePool[Alloc]` to `Standard{...}`.
  - Removed `Device::standard_pool` in favor of `Device::standard_memory_pool`.
- **Breaking** Changes to `StdDescriptorPool`:
  - Renamed `StdDescriptorPool[Alloc]` to `Standard{...}`.
  • Following up on StdDescriptorPool rewamp #1943, the way StandardCommandPool is accessed has been made consistent with StdDescriptorPool, which avoids cloning an Arc unneccessarily each time the pool is accessed.
  • Renamed Std* types to Standard* for consistency.
  • Device::standard_pool has changed signature and was renamed, so that it is more idiomatic and consistent with the rest of the API.
  • Import granularity across the crate has been made consistent.

@marc0246 marc0246 marked this pull request as draft August 7, 2022 15:55
@marc0246 marc0246 changed the title Remove unneccessary Arc-clone Changes regarding naming and API consistency Aug 7, 2022
@marc0246 marc0246 marked this pull request as ready for review August 7, 2022 17:15
@Rua
Copy link
Contributor

Rua commented Aug 7, 2022

It all looks good, thank you for helping keep Vulkano fast and consistent!

@Rua Rua merged commit c4a960d into vulkano-rs:master Aug 7, 2022
@marc0246
Copy link
Contributor Author

marc0246 commented Aug 7, 2022

No thank you ma'am, for all your hard work on maintenance!

Rua added a commit that referenced this pull request Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants