Use dedicated allocation when allocation size is large enough #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, the autogenerated title was wrong. Fixed. |
|
@ishitatsuyuki Thank you for your contribution! I will take a closer look and will perform a few local test during the week(more likely by the end of the week), but at a first glance the implementation looks fine. |
|
@ishitatsuyuki PR reviewed and merged. 👍 Thank you for your work, and I apologize for the delay in review. |
Eliah-Lakhin
added a commit
that referenced
this pull request
Jul 12, 2021
blacksailer
pushed a commit
to blacksailer/vulkano
that referenced
this pull request
Nov 25, 2021
…o-rs#1631) * Update dedicated_allocation to include Vulkan 1.1 * Fix DeviceMemoryBuilder::dedicated_info's behavior when dedicated allocation is unsupported * Use dedicated allocation when allocation size is large enough
blacksailer
pushed a commit
to blacksailer/vulkano
that referenced
this pull request
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in common words what is the purpose of this change, related Github Issues, and highlight important implementation aspects.
When allocating a buffer that is extremely large (e.g. 4.5GB), Vulkano's pool allocator would round up that to the next power of two (which is 8GB) and it failed to allocate on my GPU (which has ~7.9GB of memory available for allocation).
This PR disables memory pool allocations for memory allocation above 256MB, as they would likely lead to allocating unnecessary space as well as delaying returning freed memory to the OS. Dedicated allocations are requested when supported, which might improve efficiency but should have no drawbacks otherwise.
While on that, also fix a few condition checks since KHR_dedicated_allocation has been promoted to Vulkan 1.1.
Please put changelog entries in the description of this Pull Request
if knowledge of this change could be valuable to users. No need to put the
entries to the changelog directly, they will be transferred to the changelog
files(
CHANGELOG_VULKANO.mdandCHANGELOG_VK_SYS.md)by maintainers right after the Pull Request merge.
Large allocations now use dedicated allocations which improves memory efficiency.Run
cargo fmton the changes.N/AMake sure that the changes are covered by unit-tests.Note: The changes were tested with an application I am developing.
N/AUpdate documentation to reflect any user-facing changes - in this repository.