Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Features::superset_of to is_superset_of, add is_superset_of to extensions #1625

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Jun 28, 2021

Changelog:

- **Breaking** `Features::superset_of` is renamed to `is_superset_of`.
- Added `is_superset_of` method to `DeviceExtensions` and `InstanceExtensions`.

This fixes a small inconsistency in the naming, and adds a new method to extensions.

@Eliah-Lakhin Eliah-Lakhin merged commit aee1106 into vulkano-rs:master Jun 28, 2021
@Eliah-Lakhin
Copy link
Contributor

@Rua Merged. Thank you for the improvement!

Eliah-Lakhin added a commit that referenced this pull request Jun 28, 2021
@Rua Rua deleted the is-superset-of branch August 10, 2021 08:38
blacksailer pushed a commit to blacksailer/vulkano that referenced this pull request Nov 25, 2021
blacksailer pushed a commit to blacksailer/vulkano that referenced this pull request Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants