Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Device::active_queue_families contain no duplicates #1192

Merged
merged 1 commit into from
Jun 10, 2019

Conversation

NiklasJonsson
Copy link
Contributor

  • Added an entry to CHANGELOG_VULKANO.md or CHANGELOG_VK_SYS.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes - in this repository
  • Updated documentation to reflect any user-facing changes - PR to the guide that fixes existing documentation invalidated by this PR.

Each entry in Device::active_queue_families should be unique (as I've understood it). See for example the creation of ImmutableBuffer in Immutable::raw_impl, which will set the sharing mode to Concurrent if we have more than one (used) queue family on the device.

@knappador
Copy link
Contributor

Seems like a bug =)

which will set the sharing mode to Concurrent if we have more than one (used) queue family on the device.

This choice seems like a hack to delay implementing the buffer ownership?

There's a lot of ugly stuff in this file.

The change is more correct than what was there, so I would be happy to merge it if someday I get organization membership @rukai @tomaka

@NiklasJonsson
Copy link
Contributor Author

So is anything gonna happen here? Is there something else I should do?

@rukai
Copy link
Member

rukai commented Jun 10, 2019

Hey sorry about the wait, I am now putting my time into wgpu instead.

Good catch.
This change fixes an invalid usage of VkBufferCreateInfo and VKImageCreateInfo

If sharingMode is VK_SHARING_MODE_CONCURRENT, each element of pQueueFamilyIndices must be unique and must be less than pQueueFamilyPropertyCount returned by either vkGetPhysicalDeviceQueueFamilyProperties or vkGetPhysicalDeviceQueueFamilyProperties2 for the physicalDevice that was used to create device

@rukai rukai merged commit d98552f into vulkano-rs:master Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants