Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MutationPayload type #869

Merged
merged 2 commits into from
Jul 17, 2017
Merged

Add MutationPayload type #869

merged 2 commits into from
Jul 17, 2017

Conversation

alexjoverm
Copy link
Contributor

On the subscribe function, the mutation object was only having the type property and missing the payload

@alexjoverm
Add MutationPayload type
168220d 
On the subscribe function, the mutation object was only having the `type` property and missing the payload
@ktsn
Copy link
Member

ktsn commented Jul 17, 2017

@alexjoverm Good job 👍
Can we update the test as well?
https://github.com/vuejs/vuex/blob/dev/types/test/index.ts#L36-L39

@alexjoverm
Copy link
Contributor Author

Sure, there they are!

@ktsn
Copy link
Member

ktsn commented Jul 17, 2017

Great, thank you!

@ktsn ktsn merged commit fd2b188 into vuejs:dev Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktsn ktsn ktsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexjoverm @ktsn