Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc FR] — All files — French Translation Done #847

Merged
merged 6 commits into from
Aug 5, 2017
Merged

Conversation

MachinisteWeb
Copy link
Contributor

@MachinisteWeb MachinisteWeb commented Jun 29, 2017

We are the Vue-FR team. We provide our review on Vuex translation part (with cross consistency from others Vue documentations).

French review:

  • All FR files + 2 images : DONE

Process:

  • We will track all futur modification from en directory because in our working branch we use the en directory to work. All futur en modification at an already translated position will warns us with a conflict.
  • We reverse all work done from :working/en to :dev/fr and we will provide some pull request each time a set of pages will be translated.

Signed-off-by: Bruno Lesieur <[email protected]>
@MachinisteWeb MachinisteWeb changed the title [Translation Vone] Official French Translation from Vuejs-FR [Translation Done] Official French Translation from Vuejs-FR Jun 29, 2017
@MachinisteWeb
Copy link
Contributor Author

MachinisteWeb commented Jun 29, 2017

We have create a new branch with an history commit clean without all our working step not useful for « archive ».

If that is ok for you, this PR is ready for merge.

@MachinisteWeb MachinisteWeb changed the title [Translation Done] Official French Translation from Vuejs-FR [Translation Done] Doc French Review from Vuejs-FR Jun 29, 2017
@posva
Copy link
Member

posva commented Jun 29, 2017

ne t'en fait pas pour l'historique bordelique, on squash toujours les PR 🙂
et Merci beaucoup a toute l'equipe!! 👍

# Conflicts:
#	docs/fr/mutations.md

Signed-off-by: Bruno Lesieur <[email protected]>
@MachinisteWeb
Copy link
Contributor Author

MachinisteWeb commented Jul 13, 2017

@posva : I have just up-to-date documentation with last modifications from « testing.md ».

This PR is OK for Merge!

PS : we have add two forgotten « dot » in « testing.md »

@MachinisteWeb MachinisteWeb changed the title [Translation Done] Doc French Review from Vuejs-FR [Doc FR] — All files — French Translation Done Jul 17, 2017
@posva
Copy link
Member

posva commented Jul 17, 2017

Merci d'avoir précisé que c'était fini

@MachinisteWeb
Copy link
Contributor Author

MachinisteWeb commented Aug 1, 2017

Hi @posva,

What I can do for allows this PR to be merged?

@ktsn ktsn added the documentation Improvements or additions to documentation label Aug 5, 2017
@ktsn
Copy link
Member

ktsn commented Aug 5, 2017

@posva What is the status of this PR, can we merge this?

@posva
Copy link
Member

posva commented Aug 5, 2017 via email

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ktsn 👍

@ktsn
Copy link
Member

ktsn commented Aug 5, 2017

@posva 🙆

@ktsn ktsn merged commit cbc2f37 into vuejs:dev Aug 5, 2017
@MachinisteWeb MachinisteWeb deleted the dev branch August 5, 2017 16:00
@MachinisteWeb MachinisteWeb restored the dev branch August 5, 2017 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants