feat: add warning when .native modifier is used on native HTML elements #9884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
reviewed
Apr 17, 2019
posva
reviewed
Apr 17, 2019
Co-Authored-By: NataliaTepluhina <[email protected]>
Co-Authored-By: NataliaTepluhina <[email protected]>
posva
approved these changes
Apr 17, 2019
There was a problem hiding this comment.
LGTM, as usual with warnings, it would be nice if a native English speaker could approve the wording! @chrisvfritz @sdras 🙏
chrisvfritz
approved these changes
Apr 17, 2019
|
lgtm! |
sirlancelot
reviewed
Apr 18, 2019
Co-Authored-By: NataliaTepluhina <[email protected]>
|
很棒 |
kiku-jw
pushed a commit
to kiku-jw/vue
that referenced
this pull request
Jun 18, 2019
dukegod
added a commit
to dukegod/vue
that referenced
this pull request
Jun 21, 2019
* commit 'bad3c326a3f8b8e0d3bcf07917dc0adf97c32351': (911 commits) chore: update sponsors [ci skip] (vuejs#10158) chore: fix sponsor url [ci skip] chore: update sponsors [ci skip] (vuejs#10136) chore: update sponsors [ci skip] (vuejs#10130) chore: update sponsors [ci skip] (vuejs#10113) chore(typo): fix comment typo (vuejs#10101) chore: update sponsors [ci skip] (vuejs#10064) Create FUNDING.yml chore: update sponsors [ci skip] (vuejs#10031) chore(typo): fix README tag mismatch (vuejs#9934) chore(typo): fix typo in comments (vuejs#9995) chore: update sponsors [ci skip] (vuejs#9970) chore: update sponsors [ci skip] (vuejs#9933) fix: fix function expression regex (vuejs#9922) fix(types): fix global namespace declaration for UMD bundle (vuejs#9912) fix(compiler): Remove the warning for valid v-slot value (vuejs#9917) polish: add warning when .native modifier is used on native HTML elements (vuejs#9884) test: fix running e2e test on windows (vuejs#9909) refactor: remove useless parameter to the function removeVnodes (vuejs#9914) test: separate failing test for TS 3.4 ... # Conflicts: # packages/weex-template-compiler/build.js # packages/weex-vue-framework/factory.js # packages/weex-vue-framework/index.js
Lostlover
pushed a commit
to Lostlover/vue
that referenced
this pull request
Dec 10, 2019
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Currently if we have a
.nativemodifier applied to event handler on native HTML element, it will break the handler (you can find the minimal reproduction here).We had a discussion about it with @chrisvfritz and it was decided it would be a good solution to add a console warning for this case. This way we can warn people they are using
.nativeincorrectly: it should be used only on components not on elements.An ideal solution would be also making
.nativework on elements while throwing a warning but it might be a subject for another PR.