update toMs function. fix #4894 #8495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so it can parse floating numbers with commas instead of dots
|
hmm, this bug was fixed in Chromium a while ago (https://bugs.chromium.org/p/chromium/issues/detail?id=720222). What is the current version used by Electron? |
|
Electron 2.0.5 (current latest) uses Chromium 61.0.3163.100, the bug seems to be fixed on version 68.0.3409.0 I'll add the comment |
|
oh lol, so it wasn't fixed as long ago as I thought it was |
|
comment fixed (: |
|
I meant in the code 😆 |
|
lol, sorry! |
posva
approved these changes
Jul 16, 2018
|
That would be awesome if this was merged. I'm currently having this issues with Electron on Mac too. (However, in Windows works fine) |
f2009
pushed a commit
to f2009/vue
that referenced
this pull request
Jan 25, 2019
aJean
pushed a commit
to aJean/vue
that referenced
this pull request
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old versions of Chromium (below 61.0.3163.100) formats floating pointer numbers in a locale-dependent way, using a comma instead of a dot.
This PR makes toMs function parse it correctly, preventing unexpected behaviors.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: