Support for mutiple class names as key #2585
Merged
+50
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| if (!obj[key]) continue | ||
|
|
||
| key.split(' ').forEach(function (k) { |
There was a problem hiding this comment.
Unconditional split + forEach can be slow, and class bindings can be a hot spot so performance is important.
Let's do an key.indexOf(' ') > 1 check first, then use a normal for loop. (And abstract this into a function)
There was a problem hiding this comment.
That's what concerned me too, though I don't have an exact idea about the speed comparison between the check and a blind split.
This commit adds support for using multiple class names as key when
specifying a `:class` object, for example `<div :class="{ 'a b c': flag
}">`. Previously, doing so will trigger an uncaught
InvalidCharacterError, as spaces are not allowed in DOM tokens. Feature
request #2571 should also be satisfied by this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to replace #2581.