chore(compiler-sfc): specify prettier version (fix #13052) #13053
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #13052
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
main
branch for v2.x (or to a previous version branch)fix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
@vue/compiler-sfc
optionally uses Prettier and it is not compatible with Prettier v3.But
prettier
is not listed in thepackage.json
.It wasn't a problem with Prettier v2 because prettier is optional dependency of
component-compiler-utils
. So Prettier is installed anyway and everything works.But if some project has
Prettier@3
, then@vue/compiler-sfc
uses project's prettier and fails.There was the same issue early in component-compiler-utils. See:
This PR specifies Prettier as an
optionalDependency
of@vue/compiler-sfc
. With specified dependency, it will useprettier@2
even if a project hasprettier@3
.P.S. I used the same versions as it was in the
component-compiler-utils
. It seems it has the same code.Alternative solution: make
@vue/compiler-sfc
compatible with bothPrettier@"1 || 2"
andPrettier@3
. The problem is that it will make the compile function async.