We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.5.17-beta.0
https://github.com/vuejs/vue/blob/2efc0446b3ac1f18fff8b59215e7b60d51c41965/src/server/template-renderer/index.js
No need to repro, it's written in the code.
vue/src/server/template-renderer/index.js
Line 107 in 2efc044
Lines 139 to 141 in 2efc044
Line 160 in 2efc044
Line 184 in 2efc044
href="${this.publicPath}/${file}" src="${this.publicPath}/${file}"
The publicPath of webpackConfig.output could be empty, and it is resonable.
publicPath
webpackConfig.output
publicPath = ''
assets/css/xxx
publicPath = '/'
/assets/css/xxx
They are rather different
So we could introduce an extra judgement for this.publicPath === ''
this.publicPath === ''
Or we could just use publicPath directly.
The text was updated successfully, but these errors were encountered:
fix(server): use path.posix.join to generate public path
8175a4a
fix vuejs#8167
fix(server): use path.posix.join to generate public path (#8177)
46b8d2c
fix #8167
fix(server): use path.posix.join to generate public path (vuejs#8177)
799071c
1f778f2
HerringtonDarkholme
Successfully merging a pull request may close this issue.
Version
2.5.17-beta.0
Reproduction link
https://github.com/vuejs/vue/blob/2efc0446b3ac1f18fff8b59215e7b60d51c41965/src/server/template-renderer/index.js
Steps to reproduce
No need to repro, it's written in the code.
vue/src/server/template-renderer/index.js
Line 107 in 2efc044
vue/src/server/template-renderer/index.js
Lines 139 to 141 in 2efc044
vue/src/server/template-renderer/index.js
Line 160 in 2efc044
vue/src/server/template-renderer/index.js
Line 184 in 2efc044
The
publicPath
ofwebpackConfig.output
could be empty, and it is resonable.What is expected?
publicPath = ''
generatesassets/css/xxx
publicPath = '/'
generates/assets/css/xxx
They are rather different
What is actually happening?
publicPath = ''
andpublicPath = '/'
both generate/assets/css/xxx
So we could introduce an extra judgement for
this.publicPath === ''
Or we could just use
publicPath
directly.The text was updated successfully, but these errors were encountered: