chore: add #__NO_SIDE_EFFECTS__
notation to defineStore
#2740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2738
In
defineStore
, certain behaviors ofcreateSetupStore
andcreateOptionsStore
might prevent the bundler from performing static analysis to determine whether there are any side effects.Therefore, in this PR, the
defineStore
function is marked as having no side effects, enabling the bundler to tree-shake stores that are not used after being defined.References
https://github.com/javascript-compiler-hints/compiler-notations-spec/blob/main/no-side-effects-notation-spec.md
rollup/rollup#5024