Adds support for props defined with array of strings #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix unCamelcase parsing of entry with numbers #15 - Fix filtering of ignoredVisibilities #18 - Add support of Spread Operator #7
|
Thank you for your contribution. |
|
Could you add a test to cover the line 128 of the parser.js file please? |
|
Could you also create your PR to the |
|
@demsking Sure, I'll add test and change target branch to |
|
@demsking I think we are good to proceed. Don't hesitate if you think there is something else to improve. |
demsking
reviewed
May 30, 2018
| .catch((err) => { throw err }) | ||
|
|
||
| it('should list props from string array', () => { | ||
| const propsNames = component.props.map((item) => item.name) |
There was a problem hiding this comment.
What about item.type? I think that item.type should be equal to Any in this case. What do you think?
|
You are right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for feature request https://github.com/vuedoc/parser/issues/23