Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unCamelcase #16

Merged
merged 2 commits into from
Nov 3, 2017
Merged

fix unCamelcase #16

merged 2 commits into from
Nov 3, 2017

Conversation

ljwrer
Copy link
Contributor

@ljwrer ljwrer commented Nov 2, 2017

if text contains number,like i18n,expect to get i18n rather than i-1-8n #15

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 99.628% when pulling c48b229 on ljwrer:master into 1de6608 on vuedoc:master.

@demsking
Copy link
Member

demsking commented Nov 3, 2017

Thanks @ljwrer for your feedback. Could you just add a test that cover this case please?
Something like:

it('should succeed with entry that contains numbers', () => {
  const entry = 'i18n'
  const result = utils.unCamelcase(entry)
  const expected = 'i18n'

  assert.equal(result, expected)
})

@demsking demsking self-assigned this Nov 3, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 99.628% when pulling 76eae1c on ljwrer:master into 1de6608 on vuedoc:master.

@ljwrer
Copy link
Contributor Author

ljwrer commented Nov 3, 2017

test case added @demsking

@demsking
Copy link
Member

demsking commented Nov 3, 2017

Great!
Thanks for your PR. I'll release it soon

@demsking demsking changed the base branch from master to develop November 3, 2017 12:29
@demsking demsking merged commit 01b1ca7 into vuedoc:develop Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants