fix parser for computed properties with an explicit getter function

[pschmiedel]

Hi, I added a small fix for parsing computed properties that use the getter/setter syntax. Currently this breaks with the following error:

/path/to/node_modules/@vuedoc/md/lib/markdown.js:130
      if (prop.dependencies.length) {
                           ^

TypeError: Cannot read property 'length' of undefined
    at props.forEach (/path/to/node_modules/@vuedoc/md/lib/markdown.js:130:28)
    at Array.forEach (native)
    at Object.computed (/path/to/node_modules/@vuedoc/md/lib/markdown.js:121:11)
    at options.printOrder.forEach (/path/to/node_modules/@vuedoc/md/lib/markdown.js:218:19)
    at Array.forEach (native)
    at process.nextTick (/path/to/node_modules/@vuedoc/md/lib/markdown.js:207:24)
    at _combinedTickCallback (internal/process/next_tick.js:73:7)
    at process._tickCallback (internal/process/next_tick.js:104:9)

I'd appreciate it if you could merge this PR.

[coveralls]

Coverage decreased (-1.4%) to 98.133% when pulling e47c626 on pschmiedel:master into c1728d7 on vuedoc:master.

[demsking]

Thanks for your PR. :-)
The coverage decreased of -1.8%. Could you just add unit tests to cover your changes please?

[demsking]

This branch need to be cover by unit tests

[pschmiedel]

I added the unit tests, coverage is back up :-)

[demsking]

Good. Now you have to add a unit test to cover the case where we have a missing get() function. Some think like:

it('should parse computed prop with missing get() method', (done) => {
  const filename = './fixtures/checkbox.vue'
  const script = `
    export default {
      computed: {
        idGetter: {
          foo () {
            const value = this.value
            return this.name + value
          }
        }
      }
    }
  `
  const options = {
    source: { script },
    filename
  }
  const parser = new Parser(options)

  parser.walk().on('computed', (prop) => {
    if (prop.dependencies.length) {
      return done(new Error('Should parse computed prop without dependencies'))
    }
    done()
  })
})

[coveralls]

Coverage decreased (-0.2%) to 99.378% when pulling 05c8f74 on pschmiedel:master into c1728d7 on vuedoc:master.

[coveralls]

Coverage decreased (-0.2%) to 99.378% when pulling cd503e0 on pschmiedel:master into c1728d7 on vuedoc:master.

[coveralls]

Coverage increased (+0.009%) to 99.587% when pulling 3a6278e on pschmiedel:master into c1728d7 on vuedoc:master.

[demsking]

What if it's set()?
I think dependencies prop is about getter... is not it?
If right, the parser should only parse the getter and ignore the setter function.

[demsking]

I mistaken... your changes already cover this purpose.

[demsking]

Hum... I don't like istanbul ignore ... statement. It may a problem if we add the else statement and forget to remove the istanbul statement. I prefer to add a unit test to cover the else branch

[demsking]

I think the parser should not emit Vue syntax error here. Syntax error must be throwed by #13
The parser should only parse the get function and ignore the others one.

[pschmiedel]

I added this case because otherwise the coverage will go down (slightly) as there is no "else" case. It is fine by me to remove the else block here, should I do that?

[demsking]

Yes, the else branch is not required in this case.

[demsking]

I mistaken... your changes already cover this purpose.

[coveralls]

Coverage decreased (-0.2%) to 99.378% when pulling 3e99e20 on pschmiedel:master into c1728d7 on vuedoc:master.

[coveralls]

Coverage increased (+0.007%) to 99.585% when pulling 1025369 on pschmiedel:master into c1728d7 on vuedoc:master.

[demsking]

Finally I think the else block is require to set entry.dependencie = [].
What do you think?

[pschmiedel]

Hi, ok I will change it to return an empty array and change the test.

[pschmiedel]

Done :-)

[demsking]

Great!!!
Thank you @pschmiedel for your PR.
I'll release it soon.

[pschmiedel]

Thanks a lot for the quick response!

[pschmiedel]

I added a test for an invalid computed property, coverage is back up :-)

[coveralls]

Coverage increased (+0.008%) to 99.586% when pulling af38128 on pschmiedel:master into c1728d7 on vuedoc:master.