Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Make can output of Multiple possible types #16

Merged
merged 16 commits into from
Apr 23, 2018

Conversation

ota-meshi
Copy link
Contributor

input:

  props: {
    propB: [String, Number],
  }

output:

## props 
- `propB` ***String|Number***

reference:
https://vuejs.org/v2/guide/components-props.html#Prop-Validation
propB

@coveralls
Copy link

coveralls commented Apr 22, 2018

Coverage Status

Coverage increased (+0.02%) to 99.185% when pulling 467e9f9 on ota-meshi:custom into 11ab55d on vuedoc:master.

Copy link
Member

@demsking demsking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR :-)

lib/markdown.js Outdated
@@ -56,6 +56,13 @@ const parseValue = (value) => {
return value
}

const parseType = (type) => {
if (type && type.type === 'ArrayExpression') {
return type.elements.map((e) => e.name).join('|')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the meaning of the e variable?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide a more meaningful variable name please?

@ota-meshi
Copy link
Contributor Author

@demsking Thank you for review!
I changed the variable name, as your requested.
Please check again it.

@demsking demsking changed the base branch from master to develop April 23, 2018 12:25
@demsking demsking merged commit 90dc5e5 into vuedoc:develop Apr 23, 2018
@demsking
Copy link
Member

Merged to the develop branch. I'll release a new version soon

@demsking demsking self-assigned this Apr 23, 2018
@demsking
Copy link
Member

demsking commented May 2, 2018

Released: @vuedoc/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants