Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layout): proposal template #9

Merged
merged 5 commits into from
Jun 6, 2019
Merged

Conversation

flozero
Copy link
Member

@flozero flozero commented Jun 6, 2019

in my use case of the plugin i prefer having a full width instead of 50% i added height min content
and remote the blue focus

I propose to change layout for a full width that will delete media queries and in most of use case i saw it is more pleasant to have a full width block to see more code.

I added a height min-content for the code that will fit for the content but still overflow scroll for x

i deleted the border blue focus content on pre tag

in my use case of the plugin i prefer having a full width instead of 50% i added height min content
and remote the blue focus
@flozero flozero self-assigned this Jun 6, 2019
@flozero flozero requested a review from elevatebart June 6, 2019 21:26
@flozero flozero added the enhancement New feature or request label Jun 6, 2019
@flozero flozero added this to the 1.0 milestone Jun 6, 2019
@vue-live-bot
Copy link

vue-live-bot commented Jun 6, 2019

Warnings
⚠️

Changes were made to package-lock.json, but not to package.json.
Please remove package-lock.json changes from your pull request. Try to run git checkout master -- package-lock.json and commit changes.

⚠️ commit message does not follows conventional change log (1)

(1) : vuepress-plugin-live uses conventional change log to generate changelog automatically. It seems some of your commit messages are not following those.

Generated by 🚫 dangerJS against c435ca5

@elevatebart elevatebart merged commit 3f2446c into master Jun 6, 2019
@elevatebart elevatebart deleted the feature/design-layout branch June 6, 2019 23:02
@elevatebart
Copy link
Member

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants