Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css design improvment) #6

Merged
merged 6 commits into from
May 24, 2019
Merged

feat(css design improvment) #6

merged 6 commits into from
May 24, 2019

Conversation

flozero
Copy link
Member

@flozero flozero commented May 22, 2019

oblige d'utiliser le setimeout du coup nextTick ici pour etre sur d'attendre le rendu final.

Effectivement prismjs modifie apres le rendu la div du coup le css n'est pas applique sinon donc ecrase... Donc il faut attendre qu'il est finis son rendu pour y venir ajouter la classe

@flozero flozero requested a review from elevatebart May 22, 2019 21:41
@flozero flozero added the enhancement New feature or request label May 22, 2019
@flozero
Copy link
Member Author

flozero commented May 22, 2019

Je suis pas sur que ca vienne de moi ca

@elevatebart
Copy link
Member

Nah j’ai juste oublié de créer un dangerfile

Copy link
Member

@elevatebart elevatebart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Des commentaires surtout sur l'utilisation du !important on appelle ca un code smell

docs/README.md Outdated Show resolved Hide resolved
layout.vue Outdated Show resolved Hide resolved
flozero pushed a commit that referenced this pull request May 23, 2019
@flozero
Copy link
Member Author

flozero commented May 23, 2019

du coup c'est update. Je te laisse valider pour que je valide aussi la pr du cote docgen apres que tu es pu m'expliquer pourquoi le vue live live ^^ ? Meme si sans ca du coup ca marche pas

@elevatebart
Copy link
Member

ca te va ca ?
Styled

@elevatebart elevatebart merged commit f90696d into master May 24, 2019
@elevatebart
Copy link
Member

🎉 This PR is included in version 0.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@flozero flozero deleted the feature/css branch June 22, 2019 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants