Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move the build files to the right folder #618

Merged
merged 1 commit into from
Oct 30, 2019
Merged

fix: move the build files to the right folder #618

merged 1 commit into from
Oct 30, 2019

Conversation

elevatebart
Copy link
Member

closes #615

@elevatebart elevatebart merged commit 25f2e8a into master Oct 30, 2019
@nicooprat
Copy link

Many thanks for your reactivity. Will it be merged/published in the stable version too?

@elevatebart
Copy link
Member Author

elevatebart commented Oct 30, 2019 via email

@nicooprat
Copy link

Amazing 👍 Thanks again.

@nicooprat
Copy link

I might have done something wrong, but I just updated and I'm now getting this error:

image

I also tried to rm -rf node_modules before without luck. I do not overwrite the webpack config in styleguide.config.js.

Did I miss anything?

@elevatebart
Copy link
Member Author

Oops, forgot to account for no decided sytleguideDir

@nicooprat
Copy link

Ok, I added the styleguideDir: 'styleguide' option for now. I can confirm that nothing is written in dist folder when doing npm run styleguide:build anyway 👍

@nicooprat
Copy link

It's working again with 3.26.2. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants