Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): update react styleguidist to 9.4 #344

Merged
merged 32 commits into from
Mar 25, 2019
Merged

Conversation

elevatebart
Copy link
Member

@elevatebart elevatebart commented Mar 20, 2019

  • Adds support for es6 imports
  • make new option simpleEditor to only load the simple react editor and prism.js for even smaller bundles

@elevatebart elevatebart changed the title chore: update react styleguidist dependecy to 9 chore: update react styleguidist dependency to 9 Mar 20, 2019
@elevatebart elevatebart self-assigned this Mar 20, 2019
@elevatebart
Copy link
Member Author

I can as well override the Editor component to bring back codemirror if you prefer.
@rafaesc what is your take on it ?

@rafaesc
Copy link
Member

rafaesc commented Mar 20, 2019

@elevatebart I think that we can maintain the same library of rsg, if it doesn't affect the current view

@elevatebart
Copy link
Member Author

@rafaesc do you mean to have the same editor as React-Styleguidist (breaking change) or to keep CodeMirror ?

@elevatebart elevatebart changed the title chore: update react styleguidist dependency to 9 feat(loaders): update react styleguidist dependency to 9 Mar 20, 2019
@elevatebart
Copy link
Member Author

I made usage of the simpleEditor opt-in so that everyone can switch at their pace... no need for a major version.

@rafaesc
Copy link
Member

rafaesc commented Mar 21, 2019

@elevatebart ok I see that you are still using CodeMirror, well I wanted to use Prism because there are interesting websites that use it, but its fine also CodeMirror

@elevatebart elevatebart changed the title feat(loaders): update react styleguidist dependency to 9 feat(core): update react styleguidist dependency to 9 Mar 21, 2019
@elevatebart
Copy link
Member Author

@rafaesc I actually want to use both. the simpleEditor option is now documented

@elevatebart
Copy link
Member Author

@rafaesc, I removed all the fat from there. Only 2 parts to see, the addition of the new editor, code & documentation and the adaptation to the React-styleguidist folder structure (add lib/ everywhere)

@elevatebart
Copy link
Member Author

And the rsg-component-default alias of course

@elevatebart elevatebart changed the title feat(core): update react styleguidist dependency to 9 feat(core): update react styleguidist to 9.4 Mar 25, 2019
@elevatebart elevatebart merged commit 1ec6e64 into dev Mar 25, 2019
@elevatebart elevatebart deleted the chore-updatersg branch March 25, 2019 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants