-
-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): update react styleguidist to 9.4 #344
Conversation
I can as well override the Editor component to bring back codemirror if you prefer. |
@elevatebart I think that we can maintain the same library of rsg, if it doesn't affect the current view |
@rafaesc do you mean to have the same editor as React-Styleguidist (breaking change) or to keep CodeMirror ? |
keep codemirror by default
I made usage of the simpleEditor opt-in so that everyone can switch at their pace... no need for a major version. |
@elevatebart ok I see that you are still using CodeMirror, well I wanted to use Prism because there are interesting websites that use it, but its fine also CodeMirror |
@rafaesc I actually want to use both. the |
db69307
to
7dd14e4
Compare
when referencing default components in a component, one generates a circular reference that makes webpack crazy. to avoid that if one wants to reference a react-styleguidist component just use rsg-components-default
@rafaesc, I removed all the fat from there. Only 2 parts to see, the addition of the new editor, code & documentation and the adaptation to the React-styleguidist folder structure (add lib/ everywhere) |
And the rsg-component-default alias of course |
simple react editor
and prism.js for even smaller bundles