Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

major: upgrade-webpack #1650

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

major: upgrade-webpack #1650

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9628ce8
first compiling upgrade
elevatebart Mar 14, 2024
1f47419
it does not break
elevatebart Mar 14, 2024
067ec13
rename var
elevatebart Mar 14, 2024
163cdcd
upgrade vue too
elevatebart Mar 14, 2024
934fee7
fixes
elevatebart Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
it does not break
  • Loading branch information
@elevatebart
elevatebart committed Mar 14, 2024
commit 1f47419fa1c545e5690ab4170e4276abcd64fd01
18 changes: 2 additions & 16 deletions packages/vue-styleguidist/src/scripts/create-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,26 +13,12 @@ export default function createServer(
const { devServer: webpackDevServerConfig } = merge(
{
devServer: {
noInfo: true,
compress: true,
clientLogLevel: 'none',
hot: true,
disableHostCheck: true,
injectClient: false,
watchOptions: {
ignored: /node_modules/
},
watchContentBase: config.assetsDir !== undefined,
stats: webpackConfig.stats || false
hot: true
}
},
{
devServer: webpackConfig.devServer
},
{
devServer: {
contentBase: config.assetsDir
}
}
)

Expand All @@ -41,7 +27,7 @@ export default function createServer(
: webpackNormal

const compiler = webpack(webpackConfig)
const devServer = new WebpackDevServer(compiler, webpackDevServerConfig)
const devServer = new WebpackDevServer(webpackDevServerConfig, compiler)

// User defined customizations
if (config.configureServer) {
Expand Down
10 changes: 0 additions & 10 deletions packages/vue-styleguidist/src/scripts/make-webpack-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,16 +199,6 @@ export default function (
output: {
publicPath: config.styleguidePublicPath
},
devServer: {
// @ts-ignore wp4 compat
publicPath: config.styleguidePublicPath,
// Use 'ws' instead of 'sockjs-node' on server since we're using native
// websockets in `webpackHotDevClient`.
transportMode: 'ws',
// Prevent a WS client from getting injected as we're already including
// `webpackHotDevClient`.
injectClient: false
},
plugins: [
new webpack.HotModuleReplacementPlugin(),
new webpack.ProvidePlugin({
Expand Down