Declare esprima as dependency in package.json #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I use vue-styleguidist to create a client-side npm-project when I declare styleguidist as a dependency, and because of
esprima
package is not specified explicitly inpackage.json
- it gets resolved differently. I did see 2.7.3 and 4.0.0 versions in both of my yarn and npm lockfiles, but yarn resolves to 2.7.3 while npm to 4.0.0 in first-levelnode_modules
folder. And Esprima at 2.7.3 used UMD, and for that, syntax likeBut for 4.0.0 Esprima migrated to Typescript (I think they migrated in 3.0.0 version), and it uses ES modules. And for that, former usage of module would break (because of how named exports).
I tried to verify if it works, but because of #15 I couldn't verify it 😅.
Hope everything's clear, feel free to ask anything or edit PR!