-
-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docgen): add expanded type name when union uses in define-props ts annotation #1396
fix(docgen): add expanded type name when union uses in define-props ts annotation #1396
Conversation
🦋 Changeset detectedLatest commit: 6e74e49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This change is a breaking change in the API. I will implement it, merge it, at the same time as I merge true TypeScript support. It will be in vue-docgen-api 5.0. Working on it with @johnsoncodehk, the author of volar. See more at I wish I could say more about the timeline. |
Codecov Report
@@ Coverage Diff @@
## dev #1396 +/- ##
=======================================
Coverage 88.38% 88.39%
=======================================
Files 113 113
Lines 8466 8471 +5
Branches 1174 1177 +3
=======================================
+ Hits 7483 7488 +5
Misses 949 949
Partials 34 34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Let me rephrase that... First, this is a great PR. Unfortunately, we are not yet at a point where this can be merged in the Sorry about that, |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
I need this too. Without it the vue3+typescript setup is very hard to use. Any idea on timeline or work arounds in the meantime? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions. |
Dear stalebot, please don‘t close this issue automatically 🤝 |
Fix displaying union types as 'union' instead of 'string | number | boolean'
For example if I have such component
I would expect to see this in args table
![image](https://user-images.githubusercontent.com/22274408/188204522-6f172cdc-390f-467e-9ca0-6ae47413ddb9.png)
What I see instead
![image](https://user-images.githubusercontent.com/22274408/188204754-54996a77-e03d-48c1-8437-9ce21b092011.png)
I assume PR will close this storybookjs/storybook#16301