Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use of vue cli 3.0 beta 11 #137

Merged
merged 6 commits into from
May 27, 2018
Merged

Enable use of vue cli 3.0 beta 11 #137

merged 6 commits into from
May 27, 2018

Conversation

elevatebart
Copy link
Member

@elevatebart elevatebart commented May 22, 2018

Had to do a couple of fixes to the make-webpack-config.js as it was conflicting with the use of the preloaders vue cli uses.
Made sure that webpack loads the dev compiler and not the runtime one.
Added the resolving of the mystic @vue/cli-service/webpack.config.js and an example.

@elevatebart
Copy link
Member Author

elevatebart commented May 22, 2018

I could not manage to run unit tests locally so did not try unit testing my changes.
I did all my tests manually.

@rafaesc rafaesc merged commit 03398df into vue-styleguidist:master May 27, 2018
@rafaesc
Copy link
Member

rafaesc commented May 27, 2018

Thanks for PR,

I had to change some files and removing the plugins of vue-cli webpack because it generated errors in console.

f83faf2

I will release a new version of vue-styleguidist with this feature soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants