Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 4 support #101

Merged
merged 4 commits into from
Mar 31, 2018
Merged

Conversation

hgascoigne
Copy link
Contributor

From discussion in #97.

Changes

  • Update to webpack 4 and update all webpack loaders
  • Transition to @babel scoped packages to support [email protected]
  • Replace System.import() with import() so webpack doesn't give a deprecation warning
  • Change npm run compile to use stage-2 preset instead of individual transform plugins that are no longer supported

Everything is working for me when I compile, build, or start. Tests don't pass, but they seem to not pass for things that I did not modify. I'm assuming those tests didn't pass before?

Let me know if there is anything you need clarification on or would like changed.

@arielsalminen
Copy link
Contributor

@hgascoigne I imagine this change would drop support for Webpack 3, am I correct?

@hgascoigne
Copy link
Contributor Author

@viljamis Yes, but only because I made a small change to the webpack config which could be moved into a webpack >= v4 conditional. All of the loader updates were to support v4, but as far as I'm aware are all backwards compatible with v3. Could we make webpack a peer dependency and leave the version decision up to the user?

@rafaesc rafaesc merged commit a515997 into vue-styleguidist:master Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants