Python changes #247
Merged
Python changes #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jethron
force-pushed
the
jethron-python
branch
from
b3bfbd3
to
ace0fd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to the python packaging. CI fixes base on top of #246 so that should be reviewed first.
sdistandbdist_wheelsshould work now (setup.pyhas to be run from the project root though, rather than from thepythondir; see CI job -- linking to curl is also a bit awkward); this allows users who don't already have libucl installed to use the Python lib easily (see How to install via pip? #202)Some of the tests fail for what look like they should be expected errors, not sure if the tests are wrong or the code is. CI only tests Python 3 because the packages for 2 no longer exist in Debian's testing channel, but if we only need to test stable we can add that back in even though Py2 is almost unsupported.