fix: Changed OpenSSL check inside configure.am #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In OpenSSL 1.1.0 the `EVP_MD_CTX_create()` and `EVP_MD_CTX_destroy()` functions were renamed to `EVP_MD_CTX_new()` and `EVP_MD_CTX_free()`. Because a check for `EVP_MD_CTX_create()` was in place inside configure.am, building with newer OpenSSL versions could not be done. Checking for `EVP_MD_CTX_create` function from configure.am was replaced with a check for `CRYPTO_new_ex_data()` function. Because a [compatibility layer][1] was introduced in OpenSSL 1.1.0, no code changes are necessary. Fixes: vstakhov#203 [1]: https://github.com/openssl/openssl/blob/OpenSSL_1_1_0/include/openssl/evp.h#L500-L502
|
Won't this break old SSL libraries, such as 1.0? |
|
@vstakhov Looking through git logs, If we take into consideration only the new signature, git says that it exist starting with $ git tag --contains 3a0799977bcb154d044828e96a25a01eb478de51 | grep 'OpenSSL_0_' | head -n 1
OpenSSL_0_9_6cDid I missed something ? |
|
In this case I have no objections, merging. Thank you! |
|
hey @vstakhov does this mean there will be a new tag soon :) I'm a packager for libucl in NixOS and I would like to know when would be a good time to include these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OpenSSL 1.1.0 the
EVP_MD_CTX_create()andEVP_MD_CTX_destroy()functions were renamed to
EVP_MD_CTX_new()andEVP_MD_CTX_free().Because a check for
EVP_MD_CTX_create()was in place insideconfigure.am, building with newer OpenSSL versions could not be done.
Checking for
EVP_MD_CTX_createfunction from configure.am wasreplaced with a check for
CRYPTO_new_ex_data()function.Because a compatibility layer was introduced in OpenSSL 1.1.0,
no code changes are necessary.
Fixes: #203