Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for NULL inputs in ucl_object_compare() #207

Merged
merged 1 commit into from
Apr 4, 2020
Merged

Check for NULL inputs in ucl_object_compare() #207

merged 1 commit into from
Apr 4, 2020

Conversation

mikeowens
Copy link

The fixes segfault which crops up in C++ when you do something like the following:

auto s = obj["section"]["nonexistant"];
ASSERT_TRUE(s == nullptr);

Otherwise UCL_NULL objects segfault in comparison.

@vstakhov
Copy link
Owner

vstakhov commented Apr 4, 2020

I have totally forgot about this PR, sorry for that :(

@vstakhov vstakhov merged commit 2e528a2 into vstakhov:master Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants