Modernize CMake file with target-based includes. #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will associate include directories with individual targets using target_include_directories() instead of setting them at the directory level, which is the old style. This allows the library to be used as a sub-directory of a parent project whose targets depend on this one and CMake will handle transitive include directories based on the PUBLIC/PRIVATE parameter values we give. Also, create some namespace'd aliases for the two ucl targets, which is also in line with modern style. Tested building both the ucl and lua-ucl targets. Fixes vstakhov#190
|
ping! |
|
Merged, thank you. Sorry for a delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will associate include directories with individual targets
using
target_include_directories()instead of setting them at thedirectory level, which is the old style. This allows the library
to be used as a sub-directory of a parent project whose targets
depend on this one and CMake will handle transitive include
directories based on the
PUBLICandPRIVATEparameter valueswe give.
Also, create some namespace'd aliases for the two ucl targets,
which is also in line with modern style.
Tested building both the
uclandlua-ucltargets.Fixes #190