some small changes in default layout

[heykapil]

@vsoch Please have a look !
Compared with https://fly.io/docs.
I observed that current default layout looks like this:

https://github.com/heykapil/tw-jekyll/blob/58b8ae44af642607bd42221b489d6c36435f7268/error-web.png

instead of

https://github.com/heykapil/tw-jekyll/blob/58b8ae44af642607bd42221b489d6c36435f7268/correct-web.png

It has fixed some of glitches that were right there for me:
-Mobile menu is moving left / right while expanding.
-Content in desktop website is touching left side scroll bar (in case of more items in left side bar).

[heykapil]

Please ignore uploaded images. they are just for reference.

[vsoch]

Thank you @heykapil ! So I do think I remember making this change because (aestehetically) I thought the page was more balanced like this:

versus:

I think visually for the second one, at least for me it felt like there was too much white space between the left navigation and page content, and that's why I changed the structure there.

Perhaps the balance seems off because I didn't also move the search bar? If we remove ml-auto from the search bar we get:

If I remove the long navigation on fly.io to not have the scrollbar - I think it might look more similar to the design without the large space (as it is now, but with the sidebar moved over too?)

Clicking back and forth between the pages I think the see the difference - the fly design left navigation starts further into the page, so that particular spacing looks okay. Perhaps we should try that here (and then we can restore the removed ml-auto?

[heykapil]

Thanks @vsoch for pointing out the balanced changes that you made!
But in my case of build the problem is something like this below:
(look at left side bar being too close to content)

[vsoch]

Yeah I totally get it! So my proposal is to integrate your changes, but also shift everything slightly more to the right (so left margin is bigger) so it matches fly. Do you want to try that?

[vsoch]

And super cool you are making a matrix algebra course! 🧮

[heykapil]

Integrated these changes. Much better now. Closing this PR. Thanks again for help!

[vsoch]

So you aren’t interested in completing the work and improving the template here? I misunderstood the nature of the PR.

[heykapil]

That's not the case, I'll keep suggesting you tweaks, features, changes and possible fixes (whatever i can do to help you in this project) while creating one for teaching my students. I'm from mathematical background and not primarily a programmer, i just know a few things about static websites. Regarding PR, as discussed it was just a minor suggestion and you were aware of the changes and fixes. On 19-Mar-2022 4:30 pm, Vanessasaurus ***@***.***> wrote: So you aren’t interested in completing the work and improving the template here? I misunderstood the nature of the PR. — Reply to this email directly, view it on GitHub<#5 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AYHINSOYDJGQCAHTUPCO4S3VAWXU7ANCNFSM5RDWOFBQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you modified the open/close state.Message ID: ***@***.***>