Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some small changes in default layout #5

Closed
wants to merge 2 commits into from
Closed

Conversation

heykapil
Copy link

@vsoch Please have a look !
Compared with https://fly.io/docs.
I observed that current default layout looks like this:

https://github.com/heykapil/tw-jekyll/blob/58b8ae44af642607bd42221b489d6c36435f7268/error-web.png

instead of

https://github.com/heykapil/tw-jekyll/blob/58b8ae44af642607bd42221b489d6c36435f7268/correct-web.png

It has fixed some of glitches that were right there for me:
-Mobile menu is moving left / right while expanding.
-Content in desktop website is touching left side scroll bar (in case of more items in left side bar).

@heykapil
Copy link
Author

heykapil commented Mar 19, 2022

Please ignore uploaded images. they are just for reference.

@vsoch
Copy link
Owner

vsoch commented Mar 19, 2022

Thank you @heykapil ! So I do think I remember making this change because (aestehetically) I thought the page was more balanced like this:

image

versus:

image

I think visually for the second one, at least for me it felt like there was too much white space between the left navigation and page content, and that's why I changed the structure there.

Perhaps the balance seems off because I didn't also move the search bar? If we remove ml-auto from the search bar we get:

image

If I remove the long navigation on fly.io to not have the scrollbar - I think it might look more similar to the design without the large space (as it is now, but with the sidebar moved over too?)

image

Clicking back and forth between the pages I think the see the difference - the fly design left navigation starts further into the page, so that particular spacing looks okay. Perhaps we should try that here (and then we can restore the removed ml-auto?

@heykapil
Copy link
Author

Thanks @vsoch for pointing out the balanced changes that you made!
But in my case of build the problem is something like this below:
(look at left side bar being too close to content)
image

@vsoch
Copy link
Owner

vsoch commented Mar 19, 2022

Yeah I totally get it! So my proposal is to integrate your changes, but also shift everything slightly more to the right (so left margin is bigger) so it matches fly. Do you want to try that?

@vsoch
Copy link
Owner

vsoch commented Mar 19, 2022

And super cool you are making a matrix algebra course! 🧮

@heykapil
Copy link
Author

Integrated these changes. Much better now. Closing this PR. Thanks again for help!
ok

@heykapil heykapil closed this Mar 19, 2022
@vsoch
Copy link
Owner

vsoch commented Mar 19, 2022

So you aren’t interested in completing the work and improving the template here? I misunderstood the nature of the PR.

@heykapil
Copy link
Author

heykapil commented Mar 19, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants