Timer Bug Fix - Fixed indeterminate behavior of new timers. #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where behavior of new timers added during iteration through timer handles was indeterminate.
On master, consider that while iterating through
self.functions
, we usepairs
.So, if we have a timer that does something like this:
Now, if we run `Timer.update(1), there are two possibilities.
A. timerTwo is updated later.
pairs(self.functions)
.Timer.update
.B. timerTwo is updated immediately.
pairs(self.functions)
.Timer.update
, thus printing "does something else" immediately.To fix this issue, before starting to iterate through
self.functions
, we gather together all of the timer handles which currently exist, so that new timers will not be updated until the next call ofTimer.update()
.