Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIKA-606: Fix subsystem search result count, hide removed subsystems #441

Merged
merged 2 commits into from
Mar 11, 2024
Merged

LIKA-606: Fix subsystem search result count, hide removed subsystems #441

merged 2 commits into from
Mar 11, 2024

Conversation

bzar
Copy link
Contributor

@bzar bzar commented Mar 6, 2024 •
edited
Loading

Description

Subsystems removed form X-Road were visible with a direct link

Jira ticket reference: LIKA-606

What has changed:

  • Raise ObjectNotFound for removed subsystems if the user is not a sysadmin
  • Fix subsystem search result count

Checklist

  • Contains schema changes.
  • Schema changes require migration of existing data.
  • Contains migration script for existing data.
  • Changes should be covered by tests.
  • Changes are covered by tests.

Does this have a design impact ?

  • Yes
  • No

Add screenshots of design changes here if yes.

@bzar bzar marked this pull request as ready for review March 6, 2024 08:45
@bzar bzar merged commit 65daa4e into master Mar 11, 2024
6 checks passed
@bzar bzar deleted the LIKA-606_hide-xroad-removed-subsystems branch March 11, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zharktas Zharktas Zharktas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bzar @Zharktas