Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIKA-593: Only show subsystems with a description and services on front page #429

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

bzar
Copy link
Contributor

@bzar bzar commented Feb 14, 2024

Description

Front page featured subsystems should contain only subsystems with a description and at least one service

Jira ticket reference: LIKA-593

What has changed:

  • Added sort parameter to package_generator, defaults to default sorting
  • Modified get_homepage_datasets to filter the results based on criteria
    • The implementation fetches candidates in a paged fashion to reduce the likely amount of data fetched each front page load

Checklist

  • Contains schema changes.
  • Schema changes require migration of existing data.
  • Contains migration script for existing data.
  • Changes should be covered by tests.
  • Changes are covered by tests.

Does this have a design impact ?

  • Yes
  • No

Add screenshots of design changes here if yes.

@bzar bzar merged commit bea990e into master Feb 14, 2024
6 checks passed
@bzar bzar deleted the LIKA-593_featured-datasets-criteria branch February 16, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants